Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport now has connected and started events. #479

Merged
merged 5 commits into from
Nov 6, 2020
Merged

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Nov 5, 2020

These changes are designed so that transports can be stacked on top of each other
and each middleware transport can implement their own handshake.

BREAKING CHANGE: Add Connected event to Transport API
BREAKING CHANGE: Add Started event to Transport API
BREAKING CHANGE: ListenAsync returns a task that completes when the transport stops
BREAKING CHANGE: Remove AcceptAsync from transports

These changes are designed so that transports can be stacked on top of each other
and each middleware transport can implement their own handshake.

BREAKING CHANGE: Add Connected event to Transport API
BREAKING CHANGE: Add Started event to Transport API
BREAKING CHANGE: ListenAsync returns a task that completes when the transport stops
BREAKING CHANGE: Remove AcceptAsync from transports
@paulpach paulpach marked this pull request as ready for review November 6, 2020 06:52
@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
1.2% 1.2% Duplication

@paulpach paulpach merged commit 3e7f688 into master Nov 6, 2020
@paulpach paulpach deleted the connectevent branch November 6, 2020 14:44
github-actions bot pushed a commit that referenced this pull request Nov 6, 2020
# [59.0.0](v58.0.1...v59.0.0) (2020-11-06)

* Transport now has connected and started events. (#479) ([3e7f688](3e7f688)), closes [#479](#479)

### BREAKING CHANGES

* Add Connected event to Transport API
* Add Started event to Transport API
* ListenAsync returns a task that completes when the transport stops
* Remove AcceptAsync from transports
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

🎉 This PR is included in version 59.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant