feat: use ILPostProcessor for weaver #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaver tests need access to unity compiler api, so they have to go in an assembly with a special name. See: https://forum.unity.com/threads/how-does-unity-do-codegen-and-why-cant-i-do-it-myself.853867/#post-5646937
paulpach
changed the title
paulpach
commented
Jan 9, 2021
Assets/Mirror/Editor/Weaver/Processors/ReaderWriterProcessor.cs
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 11, 2021
# [62.0.0](v61.1.2...v62.0.0) (2021-01-11) ### Features * use ILPostProcessor for weaver ([#525](#525)) ([def64cd](def64cd)), closes [/forum.unity.com/threads/how-does-unity-do-codegen-and-why-cant-i-do-it-myself.853867/#post-5646937](https://github.com//forum.unity.com/threads/how-does-unity-do-codegen-and-why-cant-i-do-it-myself.853867//issues/post-5646937) ### BREAKING CHANGES * MirrorNG assembly no longer contains the components. Reference Mirror.Components instead. * Editor scripts are no longer weaved
|
🎉 This PR is included in version 62.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weaver now uses ILPostProcessor API from unity. This is the same thing MLAPI will use soon.
This is an internal feature from Unity that is still subject to change, see:
https://forum.unity.com/threads/how-does-unity-do-codegen-and-why-cant-i-do-it-myself.853867/#post-5646937
but it solves a lot of issues:
Note editor scripts are no longer weaved. Apparently, ILPostProcessor is not applied consistently to editor scripts. For this reason, some of the tests must now be done in runtime tests.
BREAKING CHANGE: MirrorNG assembly no longer contains the components. Reference Mirror.Components instead.
BREAKING CHANGE: Editor scripts are no longer weaved