Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid weaving editor scripts #537

Merged
merged 4 commits into from Jan 19, 2021
Merged

perf: avoid weaving editor scripts #537

merged 4 commits into from Jan 19, 2021

Conversation

paulpach
Copy link
Contributor

@paulpach paulpach commented Jan 19, 2021

Avoid weaving editor scripts including Assembly-CSharp-Editor.dll

We were already not expecting editor scripts to be weaved, but this actively prevents it.
Speeds up weaving a few seconds

Avoid weaving editor scripts,  this should fix compatibility with rewired
@paulpach paulpach changed the title fix: do not weave editor scripts fix: compatibility with rewired Jan 19, 2021
@paulpach paulpach changed the title fix: compatibility with rewired perf: avoid weaving editor scripts Jan 19, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@paulpach paulpach merged commit 42967f3 into master Jan 19, 2021
@paulpach paulpach deleted the rewired branch January 19, 2021 15:54
github-actions bot pushed a commit that referenced this pull request Jan 19, 2021
## [62.5.3](v62.5.2...v62.5.3) (2021-01-19)

### Performance Improvements

* avoid weaving editor scripts ([#537](#537)) ([42967f3](42967f3))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 62.5.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

paulpach added a commit that referenced this pull request Jan 29, 2021
Basically reverts PR #537
It did not solve the problem we intended to solve,
and it broke some code for someone.

fixes #552
paulpach added a commit that referenced this pull request Jan 29, 2021
Basically reverts PR #537
It did not solve the problem we intended to solve,
and it broke some code for someone.

fixes #552
github-actions bot pushed a commit that referenced this pull request Jan 29, 2021
## [62.9.4](v62.9.3...v62.9.4) (2021-01-29)

### Bug Fixes

* running weaver for editor scripts ([#557](#557)) ([12a1d73](12a1d73)), closes [#537](#537) [#552](#552)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant