New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: avoid weaving editor scripts #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid weaving editor scripts, this should fix compatibility with rewired
paulpach
changed the title
fix: do not weave editor scripts
fix: compatibility with rewired
Jan 19, 2021
paulpach
changed the title
fix: compatibility with rewired
perf: avoid weaving editor scripts
Jan 19, 2021
Kudos, SonarCloud Quality Gate passed! |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
## [62.5.3](v62.5.2...v62.5.3) (2021-01-19) ### Performance Improvements * avoid weaving editor scripts ([#537](#537)) ([42967f3](42967f3))
🎉 This PR is included in version 62.5.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
paulpach
added a commit
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid weaving editor scripts including Assembly-CSharp-Editor.dll
We were already not expecting editor scripts to be weaved, but this actively prevents it.
Speeds up weaving a few seconds