Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaver does not appear to run in-editor after PR #537 #552

Closed
VirtualBrightPlayz opened this issue Jan 27, 2021 · 1 comment · Fixed by #557
Closed

Weaver does not appear to run in-editor after PR #537 #552

VirtualBrightPlayz opened this issue Jan 27, 2021 · 1 comment · Fixed by #557
Labels
released

Comments

@VirtualBrightPlayz
Copy link

Describe the bug
PR #537 breaks custom network messages in the editor

Repro project
https://github.com/VirtualBrightPlayz/MirrorNGBug

To Reproduce
Steps to reproduce the behavior:
Install com.unity.nuget.mono-cecil via git URL
Install UniTask via git URL. via git URL.
Install MirrorNG from source.
Send a custom message struct.
An error or two should then be outputted to the console.

Expected behavior
Custom network messages send without error.

Screenshots
image

Desktop (please complete the following information):

Additional context
Setting line 51 of MirrorILPostProcessor.cs to return usesMirror; instead of return usesMirror && !usesMirrorEditor; seems to fix the issue.
@Trentish Trentish mentioned this issue Jan 27, 2021
Closed
paulpach added a commit that referenced this issue Jan 29, 2021
@paulpach
fix: running weaver for editor scripts
8da5205 
Basically reverts PR #537
It did not solve the problem we intended to solve,
and it broke some code for someone.

fixes #552
@paulpach paulpach mentioned this issue Jan 29, 2021
Merged
paulpach added a commit that referenced this issue Jan 29, 2021
@paulpach
fix: running weaver for editor scripts (#557)
12a1d73 
Basically reverts PR #537
It did not solve the problem we intended to solve,
and it broke some code for someone.

fixes #552
github-actions bot pushed a commit that referenced this issue Jan 29, 2021
@semantic-release-bot
chore(release): 62.9.4 [skip ci]
44f464f 
## [62.9.4](v62.9.3...v62.9.4) (2021-01-29)

### Bug Fixes

* running weaver for editor scripts ([#557](#557)) ([12a1d73](12a1d73)), closes [#537](#537) [#552](#552)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 62.9.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: running weaver for editor scripts MirageNet/Mirage
1 participant
@VirtualBrightPlayz