refactor: Remove networkAddress from NetworkManager #67
Conversation
| /// The IP address of the server that this client is connected to. | ||
| /// </summary> | ||
| [Tooltip("Network Address where client should connect to the server.")] | ||
| public string serverIp = "localhost"; |
There was a problem hiding this comment.
What if we put it in the transport instead. Do we need to this in the NetworkClient?
|
Hmmm, actually, why do we need a serverIp/hostname anywhere as a field? The GUI can keep it as a field if it wants to, it just needs to start the client and pass the hostname or uri, no real point storing it is there? |
|
Issues
======
+ Solved 1
See the complete overview on Codacy |
|
Kudos, SonarCloud Quality Gate passed!
|
# [15.0.0](14.0.1-master...15.0.0-master) (2020-03-05) ### Code Refactoring * Remove networkAddress from NetworkManager ([#67](#67)) ([e89c32d](e89c32d)) ### BREAKING CHANGES * StartClient now receives the server ip * NetworkManager no longer has NetworkAddress
* refactor: Remove networkAddress from NetworkManager * Remove networkIp from client too BREAKING CHANGE: StartClient now receives the server ip BREAKING CHANGE: NetworkManager no longer has NetworkAddress
# [15.0.0](14.0.1-master...15.0.0-master) (2020-03-05) ### Code Refactoring * Remove networkAddress from NetworkManager ([#67](#67)) ([e89c32d](e89c32d)) ### BREAKING CHANGES * StartClient now receives the server ip * NetworkManager no longer has NetworkAddress
|
🎉 This PR is included in version 15.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.