Transport Rewrite #679

James-Frowen · 2021-03-09T15:20:55Z

Todo:

This needs to split into smaller PR:

Rename NetworkConnection To NetworkPlayer (refactor: renaming NetworkConnection to NetworkPlayer #684)
- Update uses of NetworkPlayer
Remove INetworkPlayer, use smaller interfaces instead
- Split INetworkPlayer
Remove Nofity from NetworkConnection
Replace Transport with Peer
Replacce ObjectManagers with World
Remove Channels (use bool instead?)

Resources:

Concepts

World

List of NetworkIdentities
List of Player
Handles message

InterestManagerment (AOI)

uses List of NetworkIdentities and List of Player
decides which player can see which Identity

Player

owns NetworkIdentities
views NetworkIdentities (controled by AOI/Visbility)
has a connection (optional)

Peer

gate keeper
has list of connections

ISocket

gate to outside World

connections

has list of players
can send and receive data (raw byte)
- can be reliable/unreliable/notify

messages

unpacked/deserialized form of raw byte
has message Id
messages are sent between Machines, no sending remote message to local handlers

Machines

unity instance

RPC

function that exists on GameObjects
Rpc target players
if player has no connection, invoke locally
if player has connection, invoke remotely
if "send to all" repeat above for each player

paulpach · 2021-03-10T17:11:23Z

Assets/Mirage/Runtime/Transport/ISocket.cs

+        /// <para>Should be called after Poll</para>
+        /// </summary>
+        /// <param name="data">recieved data</param>
+        void Recieve(byte[] data, ref EndPoint endPoint, out int bytesReceived);


Suggested change

void Recieve(byte[] data, ref EndPoint endPoint, out int bytesReceived);

int Recieve(byte[] data, ref EndPoint endPoint);

no out parameters please

sonarcloud · 2021-03-11T17:28:08Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
38 Code Smells

0.0% Coverage
0.0% Duplication

part of Transport rewrite #679 BREAKING CHANGE: renaming NetworkConnection to NetworkPlayer

* refactor: renaming NetworkConnection to NetworkPlayer part of Transport rewrite #679 BREAKING CHANGE: renaming NetworkConnection to NetworkPlayer * renaming types in weaver tests * fixing test message * fixing xref in docs

Kerozard · 2021-03-13T19:18:22Z

Assets/Mirage/Runtime/Transport/SocketLayer/ISocket.cs

+        /// <para>Should be called after Poll</para>
+        /// </summary>
+        /// <param name="data">recieved data</param>
+        void Recieve(byte[] data, ref EndPoint endPoint, out int bytesReceived);


This seems to be a typo. It should be Receive.

Thanks for spotting this, I'll make sure fix this soon

gives clear seperate of Mirage and Peer/socketlayer

Squashed commit of the following: commit b82b889 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 25 16:31:39 2021 +0000 removing localplayer field until it is moved commit ba048f5 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 25 02:08:18 2021 +0000 moving Time back to Server/Client commit a4260fc Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 25 01:06:35 2021 +0000 adding after applying spawn payload, and only if new object commit 8be19f9 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 23:56:05 2021 +0000 fixing null commit 6c85f7f Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 23:54:55 2021 +0000 fixing tests commit 63b8f7b Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 23:54:50 2021 +0000 creating NetworkWorld - creating netwokrworld for object collection - moving collection from objectmanager to networkworld - moving events from collection to networkworld - adding add and remove methods to network world commit 9e1391d Merge: c6907cd 2d181b0 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 16:02:18 2021 +0000 Merge branch 'network-world-5' into temp1 commit c6907cd Merge: 5e578ee 826c675 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 16:02:16 2021 +0000 Merge branch 'network-world-4' into temp1 commit 5e578ee Merge: 94d2869 89ff2aa Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 16:02:15 2021 +0000 Merge branch 'network-world-3' into temp1 commit 2d181b0 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 24 00:20:26 2021 +0000 using SyncVarReceiver from com commit d2e24ef Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 16:05:18 2021 +0000 refactor: moving syncvar recieve to its own class commit 826c675 Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 19:21:22 2021 +0000 yielding before calling start commit 65c2ee8 Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 15:54:00 2021 +0000 renaming ServerUpdate to UpdateVars commit d082f8c Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 15:52:13 2021 +0000 refactor: moving syncvar sending to its own class BREAKING CHANGE: Dirty object collection is now inside SyncVarSender commit 89ff2aa Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 18:31:30 2021 +0000 adding properties to interface commit 57222bb Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 18:28:13 2021 +0000 fixing null check commit dd09f60 Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 15:41:04 2021 +0000 refactor: using interface instead of network server BREAKING CHANGE: fields and parameters using NetworkServer are now using INetworkServer Instead commit 94d2869 Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 23 15:38:16 2021 +0000 refactor: using interface instead of network client BREAKING CHANGE: fields and parameters using NetworkClient are now using INetworkClient Instead

Squashed commit of the following: commit f4482f0 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 25 18:13:10 2021 +0000 fixing compile errors commit 3671187 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 18 23:52:02 2021 +0000 using field instead of new references to server/client commit 087fa7c Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 18 17:13:45 2021 +0000 fixing use of arg commit f613f07 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 18 17:04:15 2021 +0000 fixing handler snot being called commit f2ecca2 Author: James Frowen <jamesfrowendev@gmail.com> Date: Thu Mar 18 16:21:00 2021 +0000 fixing weaver not registering messages commit 9bfee51 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 16:12:32 2021 +0000 using interface commit 03aba30 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 16:12:18 2021 +0000 marking player as sealed commit ff750b3 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:34:05 2021 +0000 fixing hostmode commit a80c56a Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:34:01 2021 +0000 adding test to check setup passes commit e8f9675 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:16:20 2021 +0000 fixing compile errors in editor tests commit 0e97990 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:08:27 2021 +0000 fixing compile errors in weaver commit 1f933a6 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:08:12 2021 +0000 fixing compile errrors in examples commit 4fc79de Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 14:06:39 2021 +0000 fixing compile errors in tests commit 6e4e9da Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 13:56:33 2021 +0000 adding use of message broke to authenticator commit d94df03 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:46:05 2021 +0000 fixing setup commit 133fe5c Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:37:21 2021 +0000 renaming test file commit 75993f7 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:36:47 2021 +0000 converting NetworkConnection to MessageBroker tests commit 2b72d81 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:36:16 2021 +0000 adding Substitute for message handler to test connections commit 2346172 Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:25:53 2021 +0000 using message handler instead of player commit b82addc Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:24:46 2021 +0000 fixing property name commit 6ffafcb Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:23:45 2021 +0000 adding MessageHandler to NetworkClient and NetworkServer commit e6a067b Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 02:11:10 2021 +0000 adding send passthrough methods to player commit 5b9094c Author: James Frowen <jamesfrowendev@gmail.com> Date: Wed Mar 17 01:54:37 2021 +0000 fixing compile errors in MessageBroker moving MessageBroker to its own file commit 00dd029 Author: James Frowen <jamesfrowendev@gmail.com> Date: Tue Mar 16 18:07:04 2021 +0000 refactor: moving message sendinng handler to new class BREAKING CHANGE: todo commit 2bccd16 Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Wed Mar 24 21:36:44 2021 +0000 chore(release): 84.0.0 [skip ci] * using interface instead of network server ([#722](#722)) ([7312bd8](7312bd8)) * fields and parameters using NetworkServer are now using INetworkServer Instead commit 7312bd8 Author: James Frowen <jamesfrowen5@gmail.com> Date: Wed Mar 24 21:24:04 2021 +0000 refactor: using interface instead of network server (#722) BREAKING CHANGE: fields and parameters using NetworkServer are now using INetworkServer Instead commit 4ff53ec Author: semantic-release-bot <semantic-release-bot@martynus.net> Date: Wed Mar 24 21:21:02 2021 +0000 chore(release): 83.0.0 [skip ci] * using interface instead of network client ([#721](#721)) ([703596a](703596a)) * fields and parameters using NetworkClient are now using INetworkClient Instead commit 703596a Author: James Frowen <jamesfrowen5@gmail.com> Date: Wed Mar 24 21:06:14 2021 +0000 refactor: using interface instead of network client (#721) BREAKING CHANGE: fields and parameters using NetworkClient are now using INetworkClient Instead commit 5be7c6a Author: James Frowen <jamesfrowen5@gmail.com> Date: Wed Mar 24 20:08:04 2021 +0000 refactor: resetting Id on stop server (#717) keep ids small if server is stoped and started commit 913c423 Author: James Frowen <jamesfrowen5@gmail.com> Date: Wed Mar 24 20:06:57 2021 +0000 refactor: adding checked to GetNextNetworkId (#716) if id wraps it will cause problems. max value should never be reached but throw incase it does rather than warpping silently

James-Frowen · 2021-03-30T00:48:26Z

new branch #749

paulpach reviewed Mar 10, 2021

View reviewed changes

James-Frowen force-pushed the transport-v2 branch from 03fc6b0 to 77a0034 Compare March 11, 2021 15:40

James-Frowen added a commit that referenced this pull request Mar 12, 2021

refactor: renaming NetworkConnection to NetworkPlayer

443d565

part of Transport rewrite #679 BREAKING CHANGE: renaming NetworkConnection to NetworkPlayer

James-Frowen mentioned this pull request Mar 12, 2021

refactor: renaming NetworkConnection to NetworkPlayer #684

Merged

James-Frowen changed the title ~~perf: rewriting transport~~ Architecture Rewrite Mar 12, 2021

Kerozard reviewed Mar 13, 2021

View reviewed changes

James-Frowen changed the title ~~Architecture Rewrite~~ Transport Rewrite Mar 23, 2021

James-Frowen added this to In progress in Architecture Rewrite via automation Mar 24, 2021

James-Frowen added 20 commits March 24, 2021 17:29

starting on interfaces

751fc45

adding methods to socket and using endpoint

35e2e69

udp socket

6fff3b5

moving buffer outside ISocket

a186797

adding bytesReceived to recieve

2a572c1

adding bind/close to Isocket

e04109e

adding supported to transportv2

f7cf9e8

adding ReceiveLoop

bdaeb07

dropping raw from name

6780e50

fixing typo

d610844

moving types to their own files

9468637

removing to and swapping order

f939176

splitting createsocket to server/client

a110271

adding Connect

a6ad740

adding new connections to ReceiveLoop

fadbae7

adding Validate for new connections

2689320

namespace

0066bcb

new connection stuff

8ba241d

removing Obsolete error

c05e3ec

making send methods private

0819a35

James-Frowen added 13 commits March 24, 2021 17:29

adding send notify and unreliable

9764c57

adding on connection update

01d7355

more connection updates

46d5a0d

implementing HandleCommand

4d7722d

implementing connect method

4bc6f1b

adding PeerUpdater

c17ddbe

Starting to use New Peer clas

d0f5b8f

moving SocketLayer to its own asmdef

9029af5

gives clear seperate of Mirage and Peer/socketlayer

adding reference to socket layer

d8de89f

implemenent part of receive and making networkplayer sealed

bf9239e

implementing udp trasnport

b4bb4a0

Peer.Connect return Connection

cf9df6b

fixing logger not found

749f17d

James-Frowen force-pushed the transport-v2 branch from 4294bfe to 749f17d Compare March 24, 2021 17:48

James-Frowen added 7 commits March 25, 2021 18:14

fixing compile errors in runtime

f2a9853

adding IDataHandler to peer

a9da428

using IdataHandler and starting to remove InetworkPlayer

158ded0

fully removng INetworkPlayers

ad99197

removing message handler

49d6a8d

James-Frowen closed this Mar 30, 2021

James-Frowen deleted the transport-v2 branch March 30, 2021 00:48

James-Frowen removed this from In progress in Architecture Rewrite Mar 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transport Rewrite #679

Transport Rewrite #679

James-Frowen commented Mar 9, 2021 •

edited

paulpach Mar 10, 2021

sonarcloud bot commented Mar 11, 2021

Kerozard Mar 13, 2021

James-Frowen Mar 13, 2021

James-Frowen commented Mar 30, 2021

	void Recieve(byte[] data, ref EndPoint endPoint, out int bytesReceived);
	int Recieve(byte[] data, ref EndPoint endPoint);

Transport Rewrite #679

Transport Rewrite #679

Conversation

James-Frowen commented Mar 9, 2021 • edited

Todo:

This needs to split into smaller PR:

Resources:

Concepts

paulpach Mar 10, 2021

Choose a reason for hiding this comment

sonarcloud bot commented Mar 11, 2021

Kerozard Mar 13, 2021

Choose a reason for hiding this comment

James-Frowen Mar 13, 2021

Choose a reason for hiding this comment

James-Frowen commented Mar 30, 2021

James-Frowen commented Mar 9, 2021 •

edited