New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetEdentityEvents WIP #88
Conversation
I think this is ready to review now. |
Here is an overview of what got changed by this pull request: Issues
======
+ Solved 10
- Added 21
See the complete overview on Codacy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job!
Check that the events are showing in the inspector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small things
# [21.0.0](20.1.0-master...21.0.0-master) (2020-03-22) ### Features * NetworkIdentity lifecycle events ([#88](#88)) ([9a7c572](9a7c572)) ### BREAKING CHANGES * NetworkBehavior no longer has virtuals for lifecycle events
NetworkIdentity now has events related to lifecycle. This means you no longer override lifecycle events in NetworkBehaviors, but you can call AddListener or hook to the events in the inspector. BREAKING CHANGE: NetworkBehavior no longer has virtuals for lifecycle events
# [21.0.0](20.1.0-master...21.0.0-master) (2020-03-22) ### Features * NetworkIdentity lifecycle events ([#88](#88)) ([9a7c572](9a7c572)) ### BREAKING CHANGES * NetworkBehavior no longer has virtuals for lifecycle events
🎉 This PR is included in version 21.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
WIP PR do not merge. Trying to figure out tests and other misc issues.