Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetEdentityEvents WIP #88

Merged
merged 19 commits into from Mar 22, 2020
Merged

NetEdentityEvents WIP #88

merged 19 commits into from Mar 22, 2020

Conversation

uweeby
Copy link
Member

@uweeby uweeby commented Mar 21, 2020

WIP PR do not merge. Trying to figure out tests and other misc issues.

@uweeby
Copy link
Member Author

uweeby commented Mar 22, 2020

I think this is ready to review now.

Assets/Mirror/Runtime/NetworkIdentity.cs Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkIdentity.cs Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkIdentity.cs Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkIdentity.cs Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkServer.cs Outdated Show resolved Hide resolved
Assets/Mirror/Tests/Editor/NetworkIdentityTests.cs Outdated Show resolved Hide resolved
@paulpach
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 10
- Added 21
           

See the complete overview on Codacy

Copy link
Contributor

@paulpach paulpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job!

Check that the events are showing in the inspector.

Assets/Mirror/Runtime/NetworkIdentity.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@paulpach paulpach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things

Assets/Mirror/Runtime/NetworkClient.cs Outdated Show resolved Hide resolved
Assets/Mirror/Runtime/NetworkIdentity.cs Outdated Show resolved Hide resolved
@paulpach paulpach merged commit 9a7c572 into MirageNet:master Mar 22, 2020
github-actions bot pushed a commit that referenced this pull request Mar 22, 2020
# [21.0.0](20.1.0-master...21.0.0-master) (2020-03-22)

### Features

* NetworkIdentity lifecycle events ([#88](#88)) ([9a7c572](9a7c572))

### BREAKING CHANGES

* NetworkBehavior no longer has virtuals for lifecycle events
github-actions bot pushed a commit that referenced this pull request Mar 22, 2020
NetworkIdentity now has events related to lifecycle.  This means you no longer override lifecycle events in NetworkBehaviors,  but you can call AddListener or hook to the events in the inspector.

BREAKING CHANGE: NetworkBehavior no longer has virtuals for lifecycle events
github-actions bot pushed a commit that referenced this pull request Mar 22, 2020
# [21.0.0](20.1.0-master...21.0.0-master) (2020-03-22)

### Features

* NetworkIdentity lifecycle events ([#88](#88)) ([9a7c572](9a7c572))

### BREAKING CHANGES

* NetworkBehavior no longer has virtuals for lifecycle events
@github-actions
Copy link
Contributor

🎉 This PR is included in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants