fix: this fixes issues with multi scene loading on server and client #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormally. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Also noticed we are setting clients not ready to all instead of checking list of players first. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
… to create the physic scene on server load with no players first.
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
made the SetAllClientsNotReady use the players passed in. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…neManagementUpgrades
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
also made it so in additive scene loading it uses the async operation to be set too. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…neManagementUpgrades
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…erwise use default server list. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
…neManagementUpgrades
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
… We never checked for when clients would unload from one scene and load to another scene and do it again over and over. This causes spawned list to null itself out because of lost references. This now allows ServerObjectManager and ClientObjectManager to check for it after scene changes. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
dragonslaya84
changed the title
feat: added a method to do physic scene loads on server and tell clients about it
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
… removalCollection list we can keep reusing because constantly reallocating and deallocating during scene load might be bad. Not sure if this is better or worse. Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
James-Frowen
requested changes
Oct 10, 2021
Signed-off-by: dragonslaya <dragonslaya.ss@gmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 107.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never checked for when clients would unload from one scene and load to another scene and do it again over and over. This causes spawned list to null itself out because of lost references. This now allows ServerObjectManager and ClientObjectManager to check for it after scene changes.