-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio Player Implementation (#21) #22
Open
Mischback
wants to merge
61
commits into
development
Choose a base branch
from
feat-audio-player
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #25 for now. ESP-IDF and ESP-ADF are provided as git submodules to the actual project repository. ESP-IDF's relevant commands (e.g. build, menuconfig) are provided using the project's Makefile. Additionally, they are integrated into VSCode using task.json and another addon to make commands available in the IDE's status bar.
Instead, make use of the embedded ESP-IDF in ESP-ADF. Basically this is just a matter of adjusting the paths in the Makefile, so this is easy enough. .vscode/c_cpp_properties.json is modified to reflect these paths.
The serial port to be used may be specified in the Makefile (ESP_SERIAL_PORT) and is provided for this development machine.
This commit includes several ugly and hackerish fixes. Obviously, a HTTP stream requires actual access to the internet, but as of now, map32 does not know if there is internet connectivity before it is setting up the audio_source (http_stream in this case). Obviously, map32 needs to know, if external peripheral devices (like internet connection, but also SD reader, ...) are ready before using them in its own codebase. I.e. in the example code, there is a call to the function ``periph_wifi_wait_for_connected(wifi_handle, portMAX_DELAY);``, which actually blocks until the WiFi is ready. This needs a lot of investigation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #21
Close #25 (as of d5baedb)
Close #26 (as of e586f79)
Consider #23, #24