Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Serious ISSUE #24

Open
lokielse opened this issue Mar 11, 2014 · 3 comments
Open

A Serious ISSUE #24

lokielse opened this issue Mar 11, 2014 · 3 comments

Comments

@lokielse
Copy link

hi, Mischi, It's an usefult directive, and please change the follow

angular.module('imageupload', [])
    .directive('image',  function($q) {...}

to

angular.module('imageupload', [])
    .directive('image', ['$q', function($q) {...}]

otherwise, it is not work after uglify. for the param $q may be converted to another name such as a,b,c,f, etc by uglify compiler.

@jdhiro
Copy link

jdhiro commented Mar 14, 2014

@lokielse
Copy link
Author

@jdhiro thanks, nice.

@boxxxie
Copy link

boxxxie commented Mar 18, 2014

maybe this repo should have a build script so that we don't have to rely on our own minification build to work, or to rely on ngmin to work (i'm on a project where ngmin actually doesn't work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants