Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to Import Event Sources - Warn if Function Does Not Exist #721

Open
mcrowson opened this issue Mar 15, 2017 · 3 comments
Open

Attempt to Import Event Sources - Warn if Function Does Not Exist #721

mcrowson opened this issue Mar 15, 2017 · 3 comments

Comments

@mcrowson
Copy link
Collaborator

Context

Feature Request to warn about typos.

In the zappa settings for events, If there are typos in event source function names, such as my recent use of a dash instead of an underscore, the error isn't apparent until zappa responds to the event and is unable to import the function used in response to the event.

Expected Behavior

For each event source in the stage, import the function to ensure it is reachable. Do this prior to uploading the zip. If the function is not reachable, raise an exception and message for the user.

"You have an event setup to call {{ function_name }}, but that that function cannot be imported. Please check for typos and ensure that the function is reachable."

Actual Behavior

Assumes function names are reachable.

@Miserlou
Copy link
Owner

Related: #78

@mcrowson mcrowson changed the title Attempt to Import Event Sources Attempt to Import Event Sources - Warn if Function Does Not Exist Mar 15, 2017
@bcongdon
Copy link
Contributor

Does Zappa do this type of check on event and exception handlers? If not, that might be good to do as well.

@mcrowson
Copy link
Collaborator Author

It does not currently. That was my use case as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants