Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

Bump up IdeaVim version #20

Open
MunsterPlop opened this issue Apr 16, 2021 · 1 comment
Open

Bump up IdeaVim version #20

MunsterPlop opened this issue Apr 16, 2021 · 1 comment

Comments

@MunsterPlop
Copy link
Contributor

MunsterPlop commented Apr 16, 2021

@Mishkun

There is an issue that I discussed it here: JetBrains/ideavim#288 with the IdeaVim maintainer:

At the moment setting plugin options in .ideavimrc only works if done before the set sneak line.

For example this doesn't work:

set sneak
let g:sneak_clevers = 1

but this does:

let g:sneak_clevers = 1
set sneak

I'll quote the IdeaVim maintainer:

Do you have the line with let g:sneaksnext=1 after set sneak line?
If yes, the line with your option was not yet parsed at the moment when sneak is initialized.
But this is incorrect behaviour and you should update IdeaVim dependency from 0.61 to 0.66.
However, the problem is that 0.66 version of IdeaVim has 2020.2+ compatibility and this plugin is 2020.1+.
So, you have two options:

- bump up the versions of IdeaVim dependency and IJ
- Make a note that line with the option should stand before set sneak

Not sure what is more convenient for you, but I thought you should be notified.
Also I think it should be good to mention for future contributions that the # symbol isn't currently supported (let g:sneak#clever_s = 1 won't work).

@AlexPl292
Copy link
Contributor

Hey, I just wanted to say that this version update would be needed for development only. I mean, on the user machine there is no such thing as "plugin A depends on the concrete version of plugin B". So, if the user has IJ with IdeaVim 0.66 and ideavim-sneak of any version, this fix about executing let g:sneak_clevers = 1 would work already.
And gradle file defines dependency to a concrete version of IdeaVim just to know what version of plugin to use for development.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants