Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #135

Closed
abenrob opened this issue Mar 3, 2016 · 10 comments
Closed

French translation #135

abenrob opened this issue Mar 3, 2016 · 10 comments

Comments

@abenrob
Copy link
Contributor

abenrob commented Mar 3, 2016

@tsamaya @ThomasG77 There are still a few items to clean up in the localization branch, but once we are settled on the EN content, that branch is primed for FR. I have started work on it, but I'm sure either of you could do a much better job. I can comment in this thread when we are ready to proceed, so we don't waste time/efforts re-doing too much stuff.

cc @dalekunce @pedrito1414

@abenrob
Copy link
Contributor Author

abenrob commented Mar 4, 2016

I believe @tsamaya is currently working on this?

@smehenni
Copy link

smehenni commented Mar 7, 2016

@abenrob @tsamaya / Let me know if you still need help on this. I can correct the mistakes and translate the remaining content.

@tsamaya
Copy link
Contributor

tsamaya commented Mar 7, 2016

Hi @smehenni,
@abenrob merge the beginning of my translation, and the last branch for it is : https://github.com/abenrob/missingmaps.github.io/tree/localization-patch2
I will not be able to work on it before Tuesday evening UTC time.
let us know what you can do.

@smehenni
Copy link

smehenni commented Mar 8, 2016

Could not create the pull request, but here's my edited version (there were a few mistakes) with the translation of the About page. I can translate the Hosting a Mapathon page tomorrow if you want! (Saved the file in .txt because I can't attach a .yml)

fr.txt

@abenrob
Copy link
Contributor Author

abenrob commented Mar 8, 2016

Thanks Sam. I'll pull it in tonight and let you know how it goes.

Sent from my iPhone

On Mar 8, 2016, at 15:57, Samuel Mehenni notifications@github.com wrote:

Could not create the pull request, but here's my edited version (there were a few mistakes) with the translation of the About page. I can translate the Hosting a Mapathon page tomorrow if you want! (Saved the file in .txt because I can't attach a .yml)

fr.txt


Reply to this email directly or view it on GitHub.

@abenrob
Copy link
Contributor Author

abenrob commented Mar 8, 2016

#143 pulls in your additions @smehenni
Additional edits should build off the patch2 branch until this is merged.

@abenrob
Copy link
Contributor Author

abenrob commented Mar 18, 2016

@tsamaya, @smehenni - would be super useful to get the translation finalized, so we can publish the translation branch, and keep branches from continuing to diverge. Extra kudos if we can wrap it this weekend. The main localization branch is now current with mine, so we need these highlighted lines translated: https://github.com/MissingMaps/missingmaps.github.io/blob/localization/app/_data/fr.yml#L152-L192
Thanks in advance !!!

@smehenni
Copy link

I'll take care of it. I'll send you an update tomorrow evening, Eastern Time.

@smehenni
Copy link

Here's my translation
Not sure how to do a new pull request for your branch though, I'm still new to GitHub. Help would be appreciated!

@abenrob
Copy link
Contributor Author

abenrob commented Mar 20, 2016

Awesome @smehenni !!!
PR #147

@abenrob abenrob mentioned this issue Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants