Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User badges system. Catch the 'no data' case #78

Closed
harry-wood opened this issue Feb 25, 2016 · 5 comments
Closed

User badges system. Catch the 'no data' case #78

harry-wood opened this issue Feb 25, 2016 · 5 comments
Assignees
@kamicut

Comments

@harry-wood
Copy link
Contributor

The user badges thing: http://www.missingmaps.org/users/#/ ..should catch the 'no data' case, and say something like

"Sorry. No data for this user. Since we started gathering data (Feb 2016) we haven't picked up any edits by this user. Go do some mapping, then come back and try again!"

Currently it silently fails logging a js error TypeError: undefined is not an object (evaluating 'user.id') rethrowCaughtErrorbundle.js:50119
@harry-wood harry-wood mentioned this issue Feb 25, 2016
Closed
@dalekunce
Copy link
Member

+1

@dalekunce dalekunce assigned dalekunce and kamicut and unassigned dalekunce Feb 25, 2016
@dalekunce
Copy link
Member

@kamicut can you have an error message and with a button/link to /contribute

@DylanMoriarty DylanMoriarty mentioned this issue Feb 26, 2016
Merged
@DylanMoriarty
Copy link

PR open for this currently in the User pages.

@harry-wood
Copy link
Contributor Author

That PR was merged. Was it deployed? This basic issue doesn't seem to be fixed (re-open?)

@harry-wood
Copy link
Contributor Author

OK now I see it's fixed on the live site. (Seeing this)

screen shot 2016-05-09 at 12 09 19

Yay!

but ...it's OpenStreetMap not OpenStreetMaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamicut kamicut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@harry-wood @kamicut @dalekunce @DylanMoriarty