Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to mute/unmute, pin/unpin and close tabs from search modal #11

Closed
MitchellMarkGeorge opened this issue Jul 4, 2022 · 3 comments · Fixed by #71
Closed

Add ability to mute/unmute, pin/unpin and close tabs from search modal #11

MitchellMarkGeorge opened this issue Jul 4, 2022 · 3 comments · Fixed by #71
Labels
enhancement New feature or request M Medium Task UI
Projects
Milestone

Comments

@MitchellMarkGeorge
Copy link
Owner

MitchellMarkGeorge commented Jul 4, 2022

For pin icons, use

  • AiFillPushpin to show pinned
  • AiOutlinePushpin to show unpined

For volume icons, use

  • HiVolumeOff to show muted
  • HiVolumeUp to show unmuted

For the close icon, use RiCloseLIne

You should only be able to mute a tab if it is currently making sounds (is audible)

@MitchellMarkGeorge MitchellMarkGeorge changed the title Add ability to mute/unmute and pin/unpin tabs from search modal Add ability to mute/unmute, pin/unpin and close tabs from search modal Jul 4, 2022
@MitchellMarkGeorge MitchellMarkGeorge added M Medium Task UI labels Jul 6, 2022
@MitchellMarkGeorge MitchellMarkGeorge added this to To do in 1.0 Jul 6, 2022
@MitchellMarkGeorge MitchellMarkGeorge added the enhancement New feature or request label Jul 6, 2022
@MitchellMarkGeorge MitchellMarkGeorge added this to the 1.0 milestone Jul 6, 2022
@MitchellMarkGeorge
Copy link
Owner Author

Do we need muting? The UI design for this seems a bit cluttered with 3 icons. Luckily we can delegate of of these aspects to an action (this will probably be tab muting)

Only two icons
Screen Shot 2022-08-02 at 10 41 20 AM

3 icons
Screen Shot 2022-08-02 at 10 42 00 AM

@MitchellMarkGeorge
Copy link
Owner Author

It is also important to note that these icons will only be shown when the tab is "selected" (also happens on mouseover)

@MitchellMarkGeorge
Copy link
Owner Author

This is what the updated UI will like with the icons

2 icons
Screen Shot 2022-08-02 at 10 47 53 AM

3 icons
Screen Shot 2022-08-02 at 10 48 31 AM

@MitchellMarkGeorge MitchellMarkGeorge moved this from To do to In progress in 1.0 Aug 2, 2022
1.0 automation moved this from In progress to Done Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request M Medium Task UI
Projects
1.0
Done
Development

Successfully merging a pull request may close this issue.

1 participant