Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding browser-wide search (not just current window) #12

Closed
MitchellMarkGeorge opened this issue Jul 6, 2022 · 3 comments · Fixed by #42
Closed

Consider adding browser-wide search (not just current window) #12

MitchellMarkGeorge opened this issue Jul 6, 2022 · 3 comments · Fixed by #42
Labels
enhancement New feature or request M Medium Task
Projects
1.0
Milestone
1.0

Comments

@MitchellMarkGeorge
Copy link
Owner

Right now the current implementation only queries tabs from the current window, but if we want to be able to search tabs browser-wide, there is a chance some things might become a bit slower (like the filtering and mapping in the background script)
@MitchellMarkGeorge MitchellMarkGeorge created this issue from a note in 1.0 (To do) Jul 6, 2022
@MitchellMarkGeorge MitchellMarkGeorge added enhancement New feature or request M Medium Task labels Jul 6, 2022
@MitchellMarkGeorge MitchellMarkGeorge added this to the 1.0 milestone Jul 6, 2022
@MitchellMarkGeorge
Copy link
Owner Author

This would definitely require virtualization to be implemented before going forward

@MitchellMarkGeorge
Copy link
Owner Author

A suitable solution to this would be to have a toggle in the bottom bar that filters optionally filters to only tabs in the current window. This would require a state to track this and an additional inCurrentWindow field in the TabData interface

@MitchellMarkGeorge MitchellMarkGeorge mentioned this issue Jul 15, 2022
Merged
1 task
@MitchellMarkGeorge
Copy link
Owner Author

This feature has been implemented in a different branch but the UI needs to be confirmed.

@MitchellMarkGeorge MitchellMarkGeorge mentioned this issue Jul 18, 2022
Merged
1 task
1.0 automation moved this from To do to Done Jul 18, 2022
@MitchellMarkGeorge MitchellMarkGeorge mentioned this issue Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request M Medium Task
Projects
1.0
Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Browser wide search MitchellMarkGeorge/TabButler
1 participant
@MitchellMarkGeorge