Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more stats at end of each test #16

Closed
Mithil467 opened this issue Sep 19, 2020 · 12 comments · Fixed by #64
Closed

Show more stats at end of each test #16

Mithil467 opened this issue Sep 19, 2020 · 12 comments · Fixed by #64
Assignees
Labels
Milestone

Comments

@Mithil467
Copy link
Owner

Currently we are only displaying the typing speed. We can add other attributes like Accuracy and Time taken nearby.

@Mithil467 Mithil467 added enhancement New feature or request good first issue Good for newcomers Hacktoberfest First-timers labels Sep 19, 2020
@p4mela-g
Copy link
Contributor

p4mela-g commented Sep 24, 2020

I have interest in doing this and I'm going to open a PR during Hacktoberfest!
Can you give me more details?

@Mithil467
Copy link
Owner Author

Hi @gudeliauskaspam 👋
Thanks for your interest!

Currently we are displaying the following test at the end of the test:

 Your typing speed is  61.20  WPM

 Press  Enter  to see a replay! 

We can also display additional stats such as:

 Your typing speed is  61.20  WPM
 Time taken: 35 sec
 Accuracy: 92.3 %

 Press  Enter  to see a replay! 

Feel free to suggest different ways to do so, or different stats if you have them on your mind! 💚

@p4mela-g
Copy link
Contributor

I want to count how many times the user typed wrong, do you mind giving a tip of in which part of the code can I implement it?
I'm a beginner and I'm having a little trouble to understand some parts.
Thanks! :)

@Mithil467
Copy link
Owner Author

No problem @gudeliauskaspam :)

Firstly you might need a class property to keep track of mistyped characters' count. That property e.g. mistyped_char_count should go inside class App() declaration in app.py. The method to calculate the accuracy should go into calculations.py.

check_word method in app.py should give you some info about checking mistyped characters.

Please feel free to ask further help or clarification if required 👍🏼

@Mithil467
Copy link
Owner Author

Hey @gudeliauskaspam 👋
Havent heard from you in a while.
Just wanted to know whether you are still interested in working on this issue?

@p4mela-g
Copy link
Contributor

p4mela-g commented Oct 3, 2020

Hey! sorry for the lack of information, I'm still working on it, I was a little busy with college, next week I'll open the pull request.

@p4mela-g
Copy link
Contributor

p4mela-g commented Oct 7, 2020

Heyy @Mithil467,
I have a question I would like to share.
When we type an incorrect character if we give backspace we can correct it, even if we have this option, do you think that the accuracy implementation still makes sense?

@Mithil467
Copy link
Owner Author

Mithil467 commented Oct 8, 2020

Yes it does! @gudeliauskaspam

If user types any character, we increment total_chars_typed (ignoring keys like backspace).
If user types a wrong character, we increment wrongly_typed_char_count.

We would use this formula Accuracy = (total_chars_typed - wrongly_typed_char_count) / total_chars_typed.

So if user hits a wrong key, we immediately take a note of it. Now even if they corrects it, the accuracy has been recorded.

Does this clarify things? If not feel free to ask :)

@Mithil467
Copy link
Owner Author

@gudeliauskaspam #56 was opened a few days ago to add time taken stat. So let's try and get it merged if possible.

We still have other stats to implement like the accuracy stat which you may work on :)

@p4mela-g
Copy link
Contributor

Oh sorry, I will work on it as soon as possible!

@Mithil467
Copy link
Owner Author

Was just notifying you about it :)
No worries 👍🏼

@Mithil467 Mithil467 added this to the v0.2.1 milestone Oct 17, 2020
@p4mela-g
Copy link
Contributor

Dooone! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants