Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New languages support #50

Closed
LucaPalumbo opened this issue Oct 4, 2020 · 1 comment
Closed

New languages support #50

LucaPalumbo opened this issue Oct 4, 2020 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@LucaPalumbo
Copy link

LucaPalumbo commented Oct 4, 2020

Hi, I think it would be nice if mitype could also support other languages like Italian, French, Spanish and so on.

Solution i'd go with
Add other tables to database. Something like data_it, data_es, data_fr... with the same columns as data
Add a commandline feature -l or --lang that let you specify which language you want to write in.
Add a function in database.py that select the text given the id from a given table.
Add a function load_based_on_language to commandline.py

I'd like to work on this. I can also populate the italian db with some phrase.

@LucaPalumbo LucaPalumbo added the enhancement New feature or request label Oct 4, 2020
@Mithil467
Copy link
Owner

Hey @LucaPalumbo 👋

Mitype currently supports loading sample text from text files. Adding text phrases for various languages might be an overkill as there are many languages! That would also increase the package size significantly! Considering these points I'll close this issue.

However, very glad to know your interest in contributing to mitype! :)

@Mithil467 Mithil467 added the wontfix This will not be worked on label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants