Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash when using custom text files larger than screen #7

Closed
klebermagno opened this issue Apr 5, 2020 · 3 comments
Closed

App crash when using custom text files larger than screen #7

klebermagno opened this issue Apr 5, 2020 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@klebermagno
Copy link

klebermagno commented Apr 5, 2020

Subject of the issue

When I try use text larger that the screen the code broke.

Your environment

  • operating-system
    Mac OS X Catalina
  • version of Mitype
    0.1.6
  • version of Python
    python 3.7.3
  • which terminal and it's version if applicable
    iterm

Problem may be in wrap_text method.

@Mithil467
Copy link
Owner

Thanks for the issue @klebermagno
Can you please share the sample text file that you were trying to use? Also, it would be great if you could share the traceback output that you receive on the terminal upon terminal crash.

@Mithil467 Mithil467 added the bug Something isn't working label Apr 5, 2020
@Mithil467
Copy link
Owner

I have made some changes now.

It would be really great if you could test running from the source directly by following the steps given here to see if the issue is indeed solved.
After confirmation, I can make a release with the latest changes.

Did the following changes -

  • Added message for user when screen size is insufficient to fit in all the lines of text (in 53fcfd0).
  • I have taken care that if user passes a file with multiple whitespaces (like tabs, newlines), the text will have only a single space instead (in b16e60f).

@Mithil467 Mithil467 added the enhancement New feature or request label Apr 5, 2020
@Mithil467 Mithil467 changed the title Broke in files larger the the screen. in using custom text files larger than the screen. Apr 5, 2020
@Mithil467 Mithil467 changed the title in using custom text files larger than the screen. App crash when using custom text files larger than screen Apr 5, 2020
@Mithil467
Copy link
Owner

I'm closing this issue. Feel free to open it if issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants