Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling a vuex action in popup.js causing an infinite loop with a wrong commit payload #41

Open
guyschlider opened this issue Jan 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@guyschlider
Copy link

Hey,

I'm trying to use this plugin in a chrome extension with a simple store:

import Vue from 'vue'
import Vuex from 'vuex'
import VuexWebExtensions from 'vuex-webextensions';

Vue.use(Vuex)

const SET_IS_ENABLED = 'SET_IS_ENABLED'

export default new Vuex.Store({
  state: {
    isEnabled: false,
  },
  mutations: {
    [SET_IS_ENABLED] (state, newV) {
      console.log('SET_IS_ENABLED with:', newV)
      state.isEnabled = newV
    }
  },
  actions: {
    updateEnabledState ({ commit }, newV) {
      console.log('updateEnabledState with: ', newV)
      commit(SET_IS_ENABLED, newV)
    }
  },
  getters: {
    isEnabled: (state) => state.isEnabled
  },
  modules: {
  },
  plugins: [VuexWebExtensions()]
})

When calling updateEnabledState I see an infinite loop:
https://i.imgur.com/DugX402.png

Using:
vue@2.6.12
vuex@3.6.0
vuex-webextensions@1.3.0

@guyschlider
Copy link
Author

Is this related to the syncActions? when setting to false - looks like its working?

@MitsuhaKitsune MitsuhaKitsune added the bug Something isn't working label Aug 4, 2021
@MitsuhaKitsune
Copy link
Owner

Recently I found this bug on the new Vuex-v4 branch, I gona investigate it and notice you here when it get fixed on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants