Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] InteractionModeManager mode detection stays on obsolete mode #803

Open
jlundycom opened this issue Jun 25, 2024 · 1 comment
Open
Labels
Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@jlundycom
Copy link

Describe the bug

When implementing a custom interactor that stays continuously active (teleport mode), I found that when the NearInteractor was detected it would switch to the NearInteractor (higher priority) and would stay on the near interactor even when not active.

To reproduce

Steps to reproduce the behavior:

  1. Create a new interactor with a detector that is always on, set it to a lower priority than near interactor.
  2. Activate the new interactor.
  3. Do a near mode interaction (while the other interactor is still valid)
  4. Stop doing the near mode interaction
  5. The near interaction mode stays active even though it is not currently being detected.

Expected behavior

When the lower priority interaction modes are no longer valid it should switch off them.

Your setup (please complete the following information)

  • Unity 2021.3.15f1
  • org.mixedrealitytoolkit.input@3.2.0

Target platform (please complete the following information)

  • Vive Pro

Additional context

Modifying the InteractionModeManager update loop and SetInteractionMode so that the firsst time a detector triggers it sets the interaction mode for the controllers fixes the problem. The previous code would only reset the default mode if no detectors triggered. If a detector triggers during the update loop it will not switch to a lower priority interactor even if the current mode is higher priority, even if no detector for the existing higher mode is triggered.

@jlundycom jlundycom added Needs: Triage Needs to be triaged. Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Jun 25, 2024
@shaynie shaynie removed the Needs: Triage Needs to be triaged. label Jun 26, 2024
@shaynie
Copy link
Contributor

shaynie commented Jun 26, 2024

@jlundycom We're focusing on the XRI 3 updates. If you have a suggested fix, please submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

No branches or pull requests

2 participants