Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python unittest assertAlmostEqual may be too permissive #153

Open
blinkseb opened this issue Jul 10, 2017 · 0 comments
Open

Python unittest assertAlmostEqual may be too permissive #153

blinkseb opened this issue Jul 10, 2017 · 0 comments

Comments

@blinkseb
Copy link
Member

We use this function in our python integration tests (https://github.com/MoMEMta/MoMEMta/blob/master/tests/bindings/python/integration_tests.py#L42 for example). Looking at the doc, this is equivalent to:

round(a-b, 7) == 0

which is probably not what we want... We can copy what's done inside Catch to be more robust here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blinkseb