Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

webpack@2 introduced a breaking change between beta22 & beta23 #767

Closed
MoOx opened this issue Sep 20, 2016 · 8 comments
Closed

webpack@2 introduced a breaking change between beta22 & beta23 #767

MoOx opened this issue Sep 20, 2016 · 8 comments
Labels

Comments

@MoOx
Copy link
Owner

MoOx commented Sep 20, 2016

Basically all configuration for eslint-loader, postcss-loader, sass-loader need to be moved out of webpack config as it's validated AND THROW ERRORS. Well... Fuck semver.

"Official" solution is to move those options into a loader plugin call...

webpack/webpack#2974 (comment)

You can say "no big deal man". But seriously, all of this because in the first place query can't handle some real JS (in a js file, that's funny right?)

This solution is not acceptable for me with my current mood as everybody will have to update more of their code. So I am not ready to cut a release with this dawn change and it's blocking us for a major release. I am pissed off, sorry for that.

Tell me what you think about the "official" solution (it's more a poor "workaround" to me)...

@DavidWells
Copy link
Contributor

O no!

@MoOx MoOx changed the title F***: webpack@2 introduced a breaking change between beta22 & beta23 webpack@2 introduced a breaking change between beta22 & beta23 Sep 20, 2016
@MoOx MoOx added bug and removed discussion labels Sep 20, 2016
@MoOx
Copy link
Owner Author

MoOx commented Sep 20, 2016

Ok this has not been clear but it seems that query accept any JS now. This will do the trick.
Also what will need to be done:

  • remove makeConfig (webpack 2 support directly a function)
  • replace "loaders" by "rules"
  • replace custom key by query directly

@thangngoc89
Copy link
Contributor

Oh craps. This release takes forever.

@MoOx
Copy link
Owner Author

MoOx commented Sep 20, 2016

This release takes forever.

This is for the better ;)

@thangngoc89
Copy link
Contributor

replace "loaders" by "rules"

What is this?

@MoOx
Copy link
Owner Author

MoOx commented Sep 20, 2016

just renaming "loaders" by "rules" in webpack.module section ( so module.loaders => modules.rules)

@thangngoc89
Copy link
Contributor

I like that changes. It's confused as hell when I worked on the loader configuration transformer

@MoOx MoOx removed the blocked label Sep 21, 2016
@MoOx
Copy link
Owner Author

MoOx commented Sep 21, 2016

Fixed (kind of) in 7ca3cb1

@MoOx MoOx closed this as completed Sep 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants