-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested custom selectors don't work #163
Comments
Seems like there are even more issues with custom selectors. @custom-selector :--any .foo, .bar;
:--any h1 {
margin-top: 16px;
} produces: .foo, .bar {
margin-top: 16px;
} |
I don't get thoses issue on the playground that is using 1.7.1... |
Mh, now I can't reproduce this on the playground too... weird O_o Well one thing I definitely still have which worked pre 1.7 @custom-selector :--checkbox-container .checkbox, .radio;
@custom-selector :--customizable input[type=checkbox]:not(:checked), input[type=checkbox]:checked,
input[type=radio]:not(:checked), input[type=radio]:checked;
:--checkbox-container > :--customizable {
position: absolute;
left: -99999px;
} Produces: .checkbox > input[type=radio]:checked,
.radio > input[type=checkbox]:not(:checked),
.radio > input[type=checkbox]:checked,
.radio > input[type=radio]:not(:checked),
.radio > input[type=radio]:checked {
position: absolute;
left: -99999px;
} Instead of: .radio > input[type=checkbox]:not(:checked),
.radio > input[type=checkbox]:checked,
.radio > input[type=radio]:not(:checked),
.radio > input[type=radio]:checked,
.checkbox > input[type=checkbox]:not(:checked),
.checkbox > input[type=checkbox]:checked,
.checkbox > input[type=radio]:not(:checked),
.checkbox > input[type=radio]:checked {
position: absolute;
left: -99999px;
} |
Okay, playground sometimes gets confused, after cutting and pasting something it produces the results from my first two posts. Refreshing I get correct results now. The above example is a bit complex, here is a much simpler one: @custom-selector :--fizzbuzz .fizz, .buzz;
@custom-selector :--foobar .foo, .bar;
:--fizzbuzz > :--foobar {
color: red;
} Produces: .fizz > .bar,
.buzz > .foo,
.buzz > .bar {
color: red;
} Instead of: .fizz > .foo,
.fizz > .bar,
.buzz > .foo,
.buzz > .bar {
color: red;
} |
It's this issue right ? csstools/postcss-custom-selectors#19 |
Yep :) |
Complete rewrite of this plugin is on the way csstools/postcss-custom-selectors#27 |
This isn't working anymore:
Now produces:
Instead of:
Seems to be working fine in plain https://github.com/postcss/postcss-custom-selectors and cssnext@1.6
The text was updated successfully, but these errors were encountered: