-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unmet peer dependency #438
Comments
can we please make this a version range instead? https://github.com/MoOx/postcss-cssnext/blob/master/package.json#L57 if not, please put it as a dep in |
@niftylettuce With a Also, You should be able to get rid of that warning by deleting |
it seems odd to not have other deps such as |
postcss plugins actually require postcss as a dep to be able to register their plugins. |
Can we please put this in as a core dependency? I'd hate to keep a separate repo maintained because otherwise end-users (using build systems like gulp or grunt) will always get this warning. I did the classic Can anyone else here test and see if they can reproduce? If it's just on my end then of course we can ignore this all completely haha. |
This change has been made 6 months ago and we only got one or 2 people opening issues fixed with an uninstall + install, so I guess everything is fine in this code. I won't make add caniuse-lite as a dep as it's not a dep, rather a recommendation for our plugin to work correctly with another given dep. |
I just tested on a new fresh repo and can't reproduce it anymore. You're right @MoOx this is just a weird edge case. Probably from working with local npm symlinks! Thanks for patience and helping me out here. |
Actually I spoke too soon! This is in fact an issue. I tested the wrong plugin, not this one. @RyanZim @MoOx here is how to reproduce (I made a test repo for you at https://github.com/niftylettuce/postcss-cssnext-test): git clone https://github.com/niftylettuce/postcss-cssnext-test.git
cd postcss-cssnext-test
yarn
# or you could do `npm install` if you're not using yarn Example output of running λ ~/Projects/postcss-css-next-test/ master* yarn
yarn install v1.3.2
info No lockfile found.
[1/4] 🔍 Resolving packages...
warning gulp > gulp-util@3.0.8: gulp-util is deprecated - replace it, following the guidelines at https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
warning gulp > vinyl-fs > graceful-fs@3.0.11: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
warning gulp > vinyl-fs > glob-stream > minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning gulp > vinyl-fs > glob-watcher > gaze > globule > minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
warning gulp > vinyl-fs > glob-watcher > gaze > globule > glob > graceful-fs@1.2.3: please upgrade to graceful-fs 4 for compatibility with current and future versions of Node.js
[2/4] 🚚 Fetching packages...
[3/4] 🔗 Linking dependencies...
warning " > postcss-cssnext@3.0.2" has unmet peer dependency "caniuse-lite@^1.0.30000697".
[4/4] 📃 Building fresh packages...
success Saved lockfile.
✨ Done in 7.75s. You can see the unmet dependency warning. Can you please re-open? |
What version of node/yarn are you using? Yarn got a tons of issues with peer deps in the past. |
yarn --version
1.3.2 npm --version
5.6.0 |
Oh, I don't get this warning on |
Thanks again for patience + help here 👍 |
The problem I see is more here imo https://github.com/yarnpkg/yarn/issues?utf8=✓&q=is%3Aissue+is%3Aopen+Unmet+peer+dependency |
documenting. with
On any yarn exec
hails from
here
|
Same issue.
|
Same here...
produce following warning
|
Also getting the same warning.
produces
|
+1 here |
postcss-cssnext has been deprecated in favor of postcss-preset-env. Read more at https://moox.io/blog/deprecating-cssnext/ |
shouldn't this be listed as a dependency instead in
package.json
?The text was updated successfully, but these errors were encountered: