Skip to content

Commit

Permalink
Two void functions that should not have return statements.
Browse files Browse the repository at this point in the history
(Proper) C doesn't let you tail-call a void returning function.
gcc lets you get away with this.
  • Loading branch information
nwc10 committed Dec 31, 2020
1 parent 34f9d8c commit 532d918
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/core/index_hash_table.c
Expand Up @@ -302,5 +302,5 @@ void MVM_index_hash_insert_nocheck(MVMThreadContext *tc,
hashtable->table = control = new_control;
}
}
return hash_insert_internal(tc, control, list, idx);
hash_insert_internal(tc, control, list, idx);
}
2 changes: 1 addition & 1 deletion src/core/threadcontext.h
Expand Up @@ -369,7 +369,7 @@ MVM_STATIC_INLINE MVMThreadContext *MVM_get_running_threads_context(void) {
}

MVM_STATIC_INLINE void MVM_set_running_threads_context(MVMThreadContext *tc) {
return uv_key_set(&MVM_running_threads_context_key, tc);
uv_key_set(&MVM_running_threads_context_key, tc);
}

#endif

0 comments on commit 532d918

Please sign in to comment.