Skip to content

Commit

Permalink
Fix unshift_* templates (no destructive '!')
Browse files Browse the repository at this point in the history
Remove destructive '!' character. As bdw explained in his feedback, the
'!' identifies an op that doesn't only fail to produce a value, but also
has a write register that is explicitly populated within the template.

Since the unshift ops don't write to a register, it is not correct to
mark it with '!'.
  • Loading branch information
jstuder-gh committed Sep 4, 2018
1 parent c1b7b54 commit 5b6d7fd
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/jit/core_templates.expr
Expand Up @@ -987,7 +987,7 @@
(carg $0 ptr)
(carg (const (&QUOTE MVM_reg_obj) int_sz) int))))

(template: unshift_i!
(template: unshift_i
(callv (^getf (^repr $0) MVMREPROps pos_funcs.unshift)
(arglist
(carg (tc) ptr)
Expand All @@ -997,7 +997,7 @@
(carg $1 ptr)
(carg (const (&QUOTE MVM_reg_int64) int_sz) int))))

(template: unshift_n!
(template: unshift_n
(callv (^getf (^repr $0) MVMREPROps pos_funcs.unshift)
(arglist
(carg (tc) ptr)
Expand All @@ -1007,7 +1007,7 @@
(carg $1 ptr)
(carg (const (&QUOTE MVM_reg_num64) int_sz) int))))

(template: unshift_s!
(template: unshift_s
(callv (^getf (^repr $0) MVMREPROps pos_funcs.unshift)
(arglist
(carg (tc) ptr)
Expand All @@ -1017,7 +1017,7 @@
(carg $1 ptr)
(carg (const (&QUOTE MVM_reg_str) int_sz) int))))

(template: unshift_o!
(template: unshift_o
(callv (^getf (^repr $0) MVMREPROps pos_funcs.unshift)
(arglist
(carg (tc) ptr)
Expand Down

0 comments on commit 5b6d7fd

Please sign in to comment.