Use larger buffer for gethostname when available

cribbed from https://github.com/ruby/ruby/blob/8099b9279b7401fa393385611a4c159900582105/ext/socket/socket.c#L888-L894
MoarVM · Oct 19, 2018 · a994f88 · a994f88
1 parent 4666ff4
commit a994f88
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/io/syncsocket.c b/src/io/syncsocket.c
@@ -47,6 +47,14 @@ MVM_NO_RETURN static void throw_error(MVMThreadContext *tc, int r, char *operati
     }
 #endif
 
+#if defined(NI_MAXHOST)
+    #define MVM_MAX_HOST_NAME_LEN NI_MAXHOST
+#elif defined(HOST_NAME_MAX)
+    #define MVM_MAX_HOST_NAME_LEN HOST_NAME_MAX
+#else
+    #define MVM_MAX_HOST_NAME_LEN 1024
+#endif
+
  /* Data that we keep for a socket-based handle. */
 typedef struct {
     /* The socket handle (file descriptor on POSIX, SOCKET on Windows). */
@@ -515,7 +523,7 @@ MVMObject * MVM_io_socket_create(MVMThreadContext *tc, MVMint64 listen) {
 }
 
 MVMString * MVM_io_get_hostname(MVMThreadContext *tc) {
-    char hostname[65];
-    gethostname(hostname, 65);
+    char hostname[MVM_MAX_HOST_NAME_LEN+1];
+    gethostname(hostname, (int)sizeof hostname);
     return MVM_string_ascii_decode_nt(tc, tc->instance->VMString, hostname);
 }