Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
make sure invalid indices for lexical vivify throw
rather than segfaulting with an invalid object later on this would be better in the bytecode validator, though.
- Loading branch information
Showing
1 changed file
with
8 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8a44b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking, but shouldn't the error message say
>=
instead of just>
?c8a44b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but if it's just describing the values,
scid
could in fact be ==effective_sf->body.cu->body.num_scs
when that exception is thrown.c8a44b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hey, the comment my second comment was a reply to disappeared?