Skip to content

Commit

Permalink
[IO] Redundant MVM_gc_mark_thread_blocked causes a panic
Browse files Browse the repository at this point in the history
Maybe panicking is an overreaction, but the mark_thread_block was
redundant, as MVM_thread_join would call it again.
  • Loading branch information
bdw committed Sep 14, 2018
1 parent 973605e commit e786a64
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/io/eventloop.c
Expand Up @@ -281,9 +281,7 @@ void MVM_io_eventloop_stop(MVMThreadContext *tc) {
uv_loop_t *loop = event_loop_thread->loop;
uv_stop(loop);

MVM_gc_mark_thread_blocked(tc);
MVM_thread_join(tc, (MVMObject*)event_loop_thread->thread_obj);
MVM_gc_mark_thread_unblocked(tc);

/* release allocated resources, this may be */
uv_close((uv_handle_t*)instance->event_loop_wakeup, NULL);
Expand Down

0 comments on commit e786a64

Please sign in to comment.