Fixed Sniper, Using pokesnipers.com & skiplagged.com #206
Conversation
| } | ||
| } | ||
|
|
||
| public class ScanResult | ||
| { | ||
| public string Status { get; set; } | ||
| public List<PokemonLocation> Pokemon { get; set; } | ||
| public List<PokemonLocation> pokemons { get; set; } |
There was a problem hiding this comment.
Its 1 pokemon, 2 pokemon, 3 pokemon..
Please change it back to Pokemon
There was a problem hiding this comment.
If this is the case, shouldn't CatchIncensePokemonsTask, CatchLurePokemonsTask, and CatchNearbyPokemonsTask be changed?
There was a problem hiding this comment.
@eslindsey I was wondering the samething as in the current/old SnipePokemonTask.cs there are multiple pokemons instead of your (@DurtyFree ) requested pokemon.
|
Please change back the PokemonsTransferFilter Dictionary default values to the ones we currently have. Please change public variables to start with a upper case and fix the outstanding conflicts @mvegter197 |
ghost
changed the title
|
@DurtyFree Fixed errors, and restored the default values. Sniping is working! |
| @@ -35,17 +37,18 @@ public class SniperInfo | |||
|
|
|||
| public class PokemonLocation | |||
| { | |||
| public PokemonLocation(double latitude, double longitude) | |||
| public PokemonLocation(double lat, double lon) | |||
There was a problem hiding this comment.
Please change this back to (double latitude, double longitude)
|
@mvegter197 Took a look at it again, seems fine, just some small stuff outstanding :) |
|
@DurtyFree Like this? |
|
@mvegter197 Much better thx! |
|
@DurtyFree that is because @Daylend fixed an issue in the old sniper version. I think that wouldn't be necessary. And @Daylend used/created the shorter words, for example the: 'expires'. |
|
@mvegter197 Yea already seen that, I told him to do a PR before because I wanted to review such stuff before its getting in. So you are not able to fix the conflicts? |
|
@DurtyFree the problem was some capital letters. |
|
@mvegter197 You should remove that last commit :D Use branches for different pull requests to avoid this |
|
@DurtyFree this is called if the sniper results in inventory full. |
ghost
closed this
ghost
reopened this
|
@DurtyFree All done! |
This reverts commit 27058b5.
|
Thx a lot for the effort:)! |
|
@DurtyFree No problem, also we can close this one #88 , might even consider a version 1.5 |
|
This code was STOLEN from work I did, and credit was not given. |
|
@SimplyPHP I found this in the necrobot github from the user that I mentioned in the first post. I wasn't aware that his was your code. |
|
@SimplyPHP Nobody cares, we all run our projects on GNU:) |
|
Credit is due where credit is due @DurtyFree. Kudos for @mvegter197 on updating his original comment with credits. |
|
Yea yea, get over it people. His reaction to the post is understood, since there is no need to get all uptight over someone using your code, it was an honest mistake. |
|
not sure if the merge was worthy, given the floating situation of the tracking sites, not a bad addition tho, if noobs won't get confused on tracking sites downtime |
Credits to @OuttaControlX and @SimplyPHP