Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarqube report invalid columns #16

Closed
LeoLogeart opened this issue Sep 20, 2021 · 6 comments
Closed

Sonarqube report invalid columns #16

LeoLogeart opened this issue Sep 20, 2021 · 6 comments

Comments

@LeoLogeart
Copy link

The startColumn and endColumn attributes of the sonarqube json output are respectively the start index and end index of the vulnerabilities. Sonar is thus unable to import the vulnerabilities.
The start and end column should be added to libast in order to easily get this value in mobfscan.

@fnxpt fnxpt mentioned this issue Sep 23, 2021
@fnxpt
Copy link

fnxpt commented Sep 23, 2021

After further investigation it looks like the position libsast is retrieving is the position of the match from the beginning of the document

@LeoLogeart
Copy link
Author

Yes that's what I meant by the start and end "index". It would probably be preferable to add the column matching in libast and applying them on mobsfscan rather than simply removing them from mobsfscan.

@fnxpt
Copy link

fnxpt commented Sep 23, 2021

Yes, but meanwhile I created a PR to remove the columns, this way we can import it on sonarqube and another to insert the match on the description

@ajinabraham
Copy link
Member

PR is merged.

@donnie-jp
Copy link

donnie-jp commented Jan 11, 2022

Hi @ajinabraham - could you make a release including this fix? We'd like to report our results to sonarqube.
Thanks

@ajinabraham
Copy link
Member

Will do shortly, I am working on some fixes and this will go along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants