Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key height minimum #47

Closed
nkrusch opened this issue Mar 2, 2021 · 0 comments · Fixed by #50
Closed

Key height minimum #47

nkrusch opened this issue Mar 2, 2021 · 0 comments · Fixed by #50
Assignees
@nkrusch
Labels
bug Something isn't working
Milestone
2.5.0

Comments

@nkrusch
Copy link
Contributor

nkrusch commented Mar 2, 2021 •
edited

Describe the bug

Got his feedback:

ThE kEyS aReNt ShOrT eNoUgH.

Expected behavior
The height is adjustable down to 6 %, for 4 rows of keys that covers 24% of viewport height in portrait. In landscape it is clamped to some other min. Maybe go down to 4% or 5% min, if the text still fits inside the keys? There maybe some extra tall ratio device out there.
@nkrusch nkrusch added the bug Something isn't working label Mar 2, 2021
@nkrusch nkrusch self-assigned this Mar 2, 2021
@nkrusch nkrusch mentioned this issue Mar 3, 2021
Merged
3 tasks
@nkrusch nkrusch linked a pull request Mar 3, 2021 that will close this issue
47: adjust minimum key height #50
Merged
3 tasks
@nkrusch nkrusch added this to the 2.5.0 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkrusch nkrusch

Labels
bug Something isn't working
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

47: adjust minimum key height MobileFirstLLC/irregular-expressions
1 participant
@nkrusch