adjust TimeFreeze on reboot rather than dropping it #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good can be better then None. There are times we'd rather have the best guess at the correct time rather than no time at all, so rather than dropping a persisted TimeFreeze on reboot, assume the current device time is consistent with the previous device time. https://jira.lyft.net/browse/NETWORK-1324
|
👮♀️ |
|
👀 @Reflejo |
Reflejo
approved these changes
Oct 17, 2017
|
I'll merge it once tests pass, thanks! |
|
🔒 @Reflejo I just realized that in order to make this all work in Lyft-iOS, I really need to just do the reset unconditionally. Because TimeFreeze is privately loaded in Clock's initialization. I'll update the PR. |
|
🔓 |
|
@Reflejo 25 minutes ago, I added another commit on craffert0/Kronos, but it's not showing up here. Should I close this and do a new PR? |
|
Ugh finally, github picked up the commit. |
|
🍔 |
|
🌍 |
|
Heads up, SQ doesn't work on public repos |
|
I've restarted the build from the travis UI for you |
craffert0
changed the title
|
🚀 I know it won't automatically work, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good can be better then None. We'd rather have the
best guess at the correct time rather than no time at all, so rather
than dropping a persisted TimeFreeze on reboot, assume the current device
time is consistent with the previous device time.