Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split up target.bzl #136

Closed
brentleyjones opened this issue Mar 11, 2022 · 2 comments · Fixed by #483
Closed

Split up target.bzl #136

brentleyjones opened this issue Mar 11, 2022 · 2 comments · Fixed by #483
Assignees
@maxwellE
Labels
cleanup Development cleanup good first issue Good for newcomers
Milestone
0.4: Improved Sim...

Comments

@brentleyjones
Copy link
Contributor

https://github.com/buildbuddy-io/rules_xcodeproj/blob/main/xcodeproj/internal/target.bzl has grown to be quite large. While everything in there doesn't really belong in any of the other .bzl files, it can still be split up a bit more.
@brentleyjones brentleyjones added good first issue Good for newcomers cleanup Development cleanup labels Mar 11, 2022
@brentleyjones brentleyjones mentioned this issue Apr 8, 2022
Merged
This was referenced Apr 8, 2022
Merged
Merged
This was referenced Apr 22, 2022
Merged
Merged
@brentleyjones brentleyjones added this to the 1.0 milestone May 24, 2022
@maxwellE
Copy link
Contributor

@brentleyjones Is this ticket complete or should we continue to move out logic from target.bzl?

@brentleyjones
Copy link
Contributor Author

brentleyjones commented May 31, 2022 •
edited
Loading

We should remove the testable, and reference the methods in the tests directly: https://github.com/buildbuddy-io/rules_xcodeproj/blob/362939844041fcd01ce2d896cf7f95e167914da8/xcodeproj/internal/target.bzl#L300-L304

We should rename process_target to create_xcodeprojinfo, remove # Creating XcodeProjInfo comment, and rename the file to xcodeprojinfo.bzl.

After that, I think this ticket is done.

@brentleyjones brentleyjones mentioned this issue May 31, 2022
Merged
@brentleyjones brentleyjones removed this from the Before 1.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxwellE maxwellE

Labels
cleanup Development cleanup good first issue Good for newcomers
Projects
None yet
Milestone
0.4: Improved Simulator and device su...
Development

Successfully merging a pull request may close this issue.

Split out final logic from target.bzl maxwellE/rules_xcodeproj
2 participants
@brentleyjones @maxwellE