Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer relative effect empiric design #11

Open
xandaau opened this issue Jan 12, 2023 · 0 comments
Open

Designer relative effect empiric design #11

xandaau opened this issue Jan 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@xandaau
Copy link
Collaborator

xandaau commented Jan 12, 2023

When we use the Designer class to design a parameter of interest, we operate on the effect input values in the following relative form: [1.01, 1.02, ...].
This is a pretty handy notation for a variable, but further we always use in our calculations and stat criteria not really these relative effects, but an absolute type of the effect.

As far as the theoretical approach is concerned, this may be fine, for empirical approaches we can make adjustments and start to distinguish between relative and absolute effects.


For empirical methods, we can implement the same functionality in the Designer class as in Tester: handling "absolute" and "relative" effects.

One way to do this is to simply start instantiating a Tester inside empiric methods(mainly stat_criterion_power method) and pass all necessary arguments to it. The Tester class already has all the implemented functions for all the statistical tests in the package.

The notation of relative effects mentioned earlier could remain the same - but now it will be an additional possible effect_type argument that will be passed to the Designer and further to the Tester, which will have two possible values "absolute" (default) and "relative".

@xandaau xandaau added the enhancement New feature or request label Jan 12, 2023
@xandaau xandaau changed the title Designer relative effect empiric design Designer relative effect empiric design Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant