Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vehicle_types_available to be empty #93

Closed
richfab opened this issue Aug 1, 2023 · 0 comments · Fixed by #94
Closed

Allow vehicle_types_available to be empty #93

richfab opened this issue Aug 1, 2023 · 0 comments · Fixed by #94
Assignees

Comments

@richfab
Copy link
Contributor

richfab commented Aug 1, 2023

Problem

In this Slack thread, @hbruch has spotted a mismatch between the specs and the JSON-Schema:

  • The specs say that vehicle_types_available in station_status.json is "used to model the total number of each defined vehicle type available at a station", which can be none. (reference)
  • But the JSON-Schema specifies that vehicle_types_available MUST have at least one item. (reference)

This causes a problem when a station has 0 vehicle available, like in the feed sample below:

Before After
Screenshot 2023-08-01 at 15 54 39 Screenshot 2023-08-01 at 15 56 07

Suggested solution

@testower suggested to remove the "minItems": 1 constraint on vehicle_types_available in https://github.com/MobilityData/gbfs-json-schema/blob/master/v3.0-RC/station_status.json#L53.

@richfab will submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant