-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positives of missing_required_field when encountering empty transfer_type values in transfers.txt #1198
Comments
Thank you for your reporting a bug. The issue has been placed in triage, the MobilityData team will follow-up on it. |
Hello Evan, Thanks for flagging this! This is super useful, having a reliable validation report is a top priority. 🙂
This is another example of a slightly blurry definition of what "empty" means in the spec. We have a similar issue with timepoint, and we ended up differentiating between (a) an empty value but an existing column, and (b) an empty column.
|
@isabelle-dr @bdferris-v2 It seems that If I understand correctly, the goal here is to generate an error notice if the column header is missing, but no notice if the header is present and the field is empty? Or is it conditional - the field should not be empty if |
@briandonahue that's correct, the goal is to generate a notice if the file It looks like This "0 or empty" semantic is often used for optional fields in the spec, I believe |
Could we use the |
@isabelle-dr I believe so. I'll just add a validator that manually checks that the header exists, and throws that notice, and remove the |
@isabelle-dr on further review - I see that there is a Then we would update the logic in |
Interesting. I think we also use |
You're correct, I missed that detail. Well, we could still do this and just add a |
Bug report
The GTFS Validator is generating false positives of the
missing_required_field
when it encounters emptytransfers.txt#transfer_type
field values.Describe the bug
Given an empty value within the
transfers.txt#transfer_type
field (which is valid according to the spec), when the validator checks the file, then it will falsely raise amissing_required_field
notice.How we reproduce the bug
Example feed: Archive.zip
In this feed in the
transfers.txt
file, the following use case is shown:This is a valid use case in that the
transfer_type
value is empty which indicates a "Recommended transfer point between routes".Expected behaviour
The validator should not flag this as an error.
Observed behaviour
The GTFS Validator flagged the above-mentioned use case as an error.
Screenshots:
See relevant JSON output for the above-linked feed.
Environment versions
The text was updated successfully, but these errors were encountered: