Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 55 (language) should be changed from ERROR to WARNING #472

Closed
mcplanner-zz opened this issue Oct 30, 2020 · 4 comments · Fixed by #726
Closed

Error 55 (language) should be changed from ERROR to WARNING #472

mcplanner-zz opened this issue Oct 30, 2020 · 4 comments · Fixed by #726
Assignees
Labels
bug Something isn't working (crash, a rule has a problem)
Milestone

Comments

@mcplanner-zz
Copy link

Describe the bug
Error code 55 appears to require that the language in agency.agency_lang matches feed_info.feed_lang. Agency_lang is optional, so this appears to be an erroneous error.

To Reproduce
Run the validator on the following dataset: http://api.511.org/transit/datafeeds?api_key=[key]&operator_id=BA

Expected behavior
No notice should be generated in this case.

Witnessed behavior
This error message was included in the validator results.

Notice{filename='feed_info.txt', level='ERROR', code='55', title='Mismatching feed and agency language fields', description='Agency `agency_name`: `Bay Area Rapid Transit` has mismatching `agency.agency_lang`: `null` and feed_info.feed_lang`: `en`.', extra='{feedInfoFeedLang=en, agencyAgencyLang=null, agencyName=Bay Area Rapid Transit}'}]

Environment used

  • OS: macOS Catalina 10.15.6
  • Java version: 11.0.5
  • gtfs-validator version: v1.2.2

Additional context
None

@mcplanner-zz mcplanner-zz assigned ghost Oct 30, 2020
@ghost ghost assigned Cristhian-HA, carlfredl and LeoFrachet and unassigned ghost Oct 30, 2020
@ghost
Copy link

ghost commented Oct 30, 2020

@Cristhian-HA :

@Fabrice-V :

  • go through the procedure qith @timMillet at 17:00 EST today to add it to our end to end

@ghost ghost added the community label Oct 30, 2020
@barbeau barbeau changed the title Error 55 (language) seems to misinterpret the specification Error 55 (language) should be changed from ERROR to WARNING Jan 21, 2021
@barbeau barbeau added bug Something isn't working (crash, a rule has a problem) and removed community labels Jan 21, 2021
@barbeau barbeau added this to the v2.0 milestone Jan 21, 2021
@lionel-nj
Copy link
Contributor

lionel-nj commented Jan 27, 2021

Related issue for v2 architecture in terms of re-introducing the concept of errors vs warnings - #549.

@lionel-nj lionel-nj linked a pull request Feb 5, 2021 that will close this issue
3 tasks
@lionel-nj lionel-nj self-assigned this Feb 5, 2021
@lionel-nj lionel-nj removed a link to a pull request Feb 8, 2021
3 tasks
@lionel-nj lionel-nj removed their assignment Feb 8, 2021
@lionel-nj
Copy link
Contributor

Will be closed by #726. This has been set to be a WARNING instead of an ERROR.

@aababilov
Copy link
Collaborator

This issue is outdated. GTFS Validator does not show any notice in that case after #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants