Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Dropdown doesn't calculate height of search field #10

Closed
AlexanderReiswich opened this issue Mar 29, 2017 · 1 comment
Closed

Dropdown doesn't calculate height of search field #10

AlexanderReiswich opened this issue Mar 29, 2017 · 1 comment
Labels

Comments

@AlexanderReiswich
Copy link

The open function seems to be based on the height of the selectr-options list and doesn't take the height of the search field into consideration:

var doInvert = _.elRect.top + _.elRect.height + _.optsRect.height > wh;

This results in a partially hidden dropdown box if it's close enough to the bottom of the window.

Additionally, because scrolling the page causes the dropdown to toggle, this makes it practically impossible to view the cut-off part of the dropdown.

It would be preferable to instead use the height of the selectr-options-container in the inversion calculation.

@Mobius1 Mobius1 added the bug label Mar 29, 2017
@Mobius1
Copy link
Owner

Mobius1 commented Mar 29, 2017

The part definitely needs overhauling and it's something I've been meaning to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants