Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format - hardcoded values #33

Open
ericc-dream opened this issue May 30, 2024 · 1 comment
Open

Date format - hardcoded values #33

ericc-dream opened this issue May 30, 2024 · 1 comment
Labels
status: planned This issue is planned to be resolved in a future release topic: documentation Improvements or additions to documentation type: enhancement New feature or request type: question Further information is requested
Milestone

Comments

@ericc-dream
Copy link
Contributor

Bug Description

Nothing important but the values in the droplist to choose the date format are hardcoded making impossible to translate them.
I see that you have added some "// TODO LAN" in the code, So I assume that you are aware
May be also, in the help, you may explain what you mean by "long", "short" and "relative" !
I have an idea for the 2 first, but "relative" puzzle me :-)

How to Reproduce

Admin -> Cookbook -> Preferences -> Date format ; droplist
You have to select another language than English, obviously

Expected Behavior

the choice translated in other languages

PHP Version

PHP Version 8.2.19

Client Information

Firefox 126.0.2 on Linux Kubuntu 23.10

@ericc-dream ericc-dream added the type: bug Something isn't working label May 30, 2024
@Moc Moc added type: enhancement New feature or request status: planned This issue is planned to be resolved in a future release and removed type: bug Something isn't working labels Jun 4, 2024
@Moc
Copy link
Owner

Moc commented Jun 4, 2024

Yeah still need to finish the LAN before releasing, thanks for the reminder.

The "long" and "short" date formats are defined in the e107 preferences. Go to Admin Area > Preferences > Date Display Options and you'll see.

"Relative" means that it shows how long ago it was relative to "now". So it could "5 minutes ago" or "3 weeks ago".

@Moc Moc added type: question Further information is requested topic: documentation Improvements or additions to documentation labels Jun 4, 2024
@Moc Moc added this to the 1.0.0 milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This issue is planned to be resolved in a future release topic: documentation Improvements or additions to documentation type: enhancement New feature or request type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants