InlineExportHelper
should use a hash of the function's mangled names for export helper names to reduce diff churn
#213
Labels
Area-OutputGeneration
Issues concerning the process of generating output from Biohazrd
Concept-InlineExpectation
Issues concerning problems around C++'s expectation for something to be inlined.
Projects
It is useful to be able to use diffs to see how changes in Biohazrd affect the output of a given library's generation. However right now
InlineExportHelper
output tends to cause a lot of annoying-to-read diff churn when its output is affected in all but the most trivial ways.Instead of using a monotonically increasing number we should use a hash of the function's mangled name. (Can't use the unmangled name because of overloads.)
One downside of using mangled names is that they will be different between platforms. Might consider something else like a hash of the function type's Clang spelling or the canonical location of the function. (Spelling might be hard to get right and be slow. Canonical location will cause a different type of churn when the library is updated.)
The text was updated successfully, but these errors were encountered: