Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch -> MDF pipeline #23

Closed
pgleeson opened this issue Mar 17, 2021 · 1 comment
Closed

PyTorch -> MDF pipeline #23

pgleeson opened this issue Mar 17, 2021 · 1 comment
Assignees

Comments

@pgleeson
Copy link
Member

@davidt0x @patrickstock Can you add details on status?

@davidt0x
Copy link
Contributor

Rough version of the torchscript to MDF translator in modeci_mdf.export.torchscript. Still a work in progress.

  • Parsing and translation of TorchScript IR graph to MDF
  • Removal of constant TorchScript nodes (they become parameters in MDF)
  • No execution, the MDF is full of TorchScript operators, working on this now.
  • Consolidation (maybe removal) of some primitive operators that TorchScript uses a lot (prim::ListConstruct, prim::TupleConstruct). I think we can flesh out the MDF spec a bit more to allow tuples and lists of parameters and input ports to be passed as arguments to functions. I think this would allow us to remove a lot these.
  • Control flow is still not handled really. Loop and If operators are translated but the blocks (subgraphs that contain their computations) are not being recursively generated in MDF. I had something working but there is a bug. Need to think about this a bit in light of the conditions stuff.

@jdcpni jdcpni closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants