Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles don't affect the download list anymore #1427

Closed
isanae opened this issue Feb 23, 2021 · 4 comments
Closed

Styles don't affect the download list anymore #1427

isanae opened this issue Feb 23, 2021 · 4 comments
Labels
Milestone

Comments

@isanae
Copy link
Contributor

isanae commented Feb 23, 2021

The widget type was changed from DownloadListWidget to DownloadListView. We need to either fix all the qss files or just rename it back.

@isanae isanae added the bug label Feb 23, 2021
@isanae isanae added this to the 2.4.1 milestone Feb 23, 2021
@Holt59
Copy link
Member

Holt59 commented Feb 23, 2021

I'll fix the .qss, I changed the name because it was inconsistent with the other tree views.

@isanae
Copy link
Contributor Author

isanae commented Feb 23, 2021

There's a bunch of them, some in repos we don't control, so they will need PRs and hope owners will accept them.

@Holt59
Copy link
Member

Holt59 commented Feb 23, 2021

There's a bunch of them, some in repos we don't control, so they will need PRs and hope owners will accept them.

Yes, we'll see. If don't think all the themes require change (some seems to be working fine).

@Holt59
Copy link
Member

Holt59 commented Feb 23, 2021

PRs opened.

  • The mob PR will update most 3rd-party themes, except the new "Transparent Morrowind" theme, but it does not use DownloadListWidget so it's fine.
  • The modorganizer PR will update all the other themes.

So this should cover everything (for the download list).

@Holt59 Holt59 closed this as completed Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants