Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement traits of external crates #10

Closed
daxpedda opened this issue Oct 31, 2021 · 2 comments · Fixed by #15
Closed

Implement traits of external crates #10

daxpedda opened this issue Oct 31, 2021 · 2 comments · Fixed by #15

Comments

@daxpedda
Copy link
Collaborator

We discussed implementing this for Zeroize for example, this might not be necessary if Zeroize can be fixed with a PR.
We should explore this further.

@ModProg
Copy link
Owner

ModProg commented Oct 31, 2021

While 3rd party crates can be fixed via a PR, this adds a new syntax for each crate, so being able to do it with a standard way might be interesting in itself, the only issue is that that adds more traits to maintain which could be unstable.

@daxpedda
Copy link
Collaborator Author

We probably will need to implement something like this too then:

  • #[derive_where(Zeroize(drop)] à la #[zeroize(drop)]
  • #[derive_where(Zeroize(crate = "zeroize_")] à la #[serde(crate = "..."]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants