Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate decision to not add support for nightly diagnostics API #15

Open
ModProg opened this issue Oct 23, 2023 · 2 comments
Open

Reevaluate decision to not add support for nightly diagnostics API #15

ModProg opened this issue Oct 23, 2023 · 2 comments

Comments

@ModProg
Copy link
Owner

ModProg commented Oct 23, 2023

While the diagnostics are still nightly, they are able to produce significantly better error messages, it could make sense to support them both to prepare for eventual stabilization and to improve the usage in nightly crates.
@ModProg ModProg changed the title Reevaluate decision to not add explicit support for nightly diagnostics API Reevaluate decision to not add support for nightly diagnostics API Oct 23, 2023
@JustusFluegel
Copy link

It would be possible to enable them using conditional compilation if manyhow is compiled on a nightly compiler.

@ModProg
Copy link
Owner Author

ModProg commented Nov 25, 2023

It would be possible to enable them using conditional compilation if manyhow is compiled on a nightly compiler.

yeah that would be the idea, and at some point when they stabelize we could remove the generation of the compile_error!{} completly.

@ModProg ModProg mentioned this issue Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ModProg @JustusFluegel