Added option to disable generated Waystone drops (fixes #156) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally the proper info would be set for the dummy TE during placement too, but since all these issues will probably solve themselves with the 1.14 cleanup this is fine for a workaround until then. |
|
Yep I considered just updating it all on creation too. I thought for a PR this would be a little less aggressive of a solution though. Plus I didn't understand the reason for the dummy TE, so I didn't want to mess too much with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this'd be a pretty simple feature, but it turned out to have some surprises. Namely that it wasn't possible to get the waystone's true TE when harvestBlock was fired. If you mined the top half, the passed-in TE contained false information.
I came up with a small workaround. We essentially update the top half during an early phase of the breaking to give it the correct information. The code comments explain it in more detail.