Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to remove the subtitle in plots #11

Closed
hbaniecki opened this issue Oct 21, 2022 · 2 comments · Fixed by #15
Closed

Allow the user to remove the subtitle in plots #11

hbaniecki opened this issue Oct 21, 2022 · 2 comments · Fixed by #15
Assignees
Labels
invalid ❕ This doesn't seem right

Comments

@hbaniecki
Copy link
Member

At this moment, plot functions with the subtitle parameter have it set to NULL as default.

Therefore, it is not possible for the user to remove the subtitle using the conventional subtitle=NULL value.

Perhaps set a different default value? It is clearly not NULL, because the subtitle appears by deafult.

if (is.null(subtitle)) {
glm_labels <- paste0(label, collapse = ", ")
subtitle <- paste0("created for the ", glm_labels, " model")
}

@mikolajsp
Copy link
Collaborator

You can set it to "" for no subtitle but I agree NULL as default parameter isn't the best option.

@hbaniecki
Copy link
Member Author

"" creates a margin between the title and plot.

@hbaniecki hbaniecki added the invalid ❕ This doesn't seem right label Oct 21, 2022
@hbaniecki hbaniecki self-assigned this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❕ This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants