New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor feature importance code #28

Closed

hbaniecki opened this issue Jan 14, 2023 · 0 comments · Fixed by #52

Assignees

Labels

maintenance 🔨

Member

hbaniecki commented Jan 14, 2023

rename permutation to _permutation_, times to _times_ and reference to _reference_ to omit potential problems with feature names

survex/R/surv_feature_importance.R

Line 160 in 64e96d6

raw$permutation <- rep(1:B, each = length(times))

survex/R/surv_feature_importance.R

Line 156 in 64e96d6

cbind(data.frame(times = times), "_full_model_" = loss_full, loss_variables, "_baseline_" = loss_baseline)
use ret[['_reference_']] instead of ret[, ncol(ret)] for readability and code robustness

survex/R/surv_feature_importance.R

Line 175 in 64e96d6

res[, 2:(ncol(res) - 3)] <- res[, 2:(ncol(res) - 3)] / res[, (ncol(res))]
sort the result by _permutation_ after merge() like it is done in type="raw"

survex/R/surv_feature_importance.R

Line 170 in 64e96d6

res <- merge(res, res_full, by = "times")

The text was updated successfully, but these errors were encountered:

hbaniecki added the maintenance 🔨 label

mikolajsp self-assigned this

mikolajsp linked a pull request

that will close this issue

Refactoring of feature importance code #52

Merged

krzyzinskim closed this as completed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment