Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In PDP categorical_variables argument is unintuitive #39

Closed
mikolajsp opened this issue Jan 18, 2023 · 1 comment · Fixed by #55
Closed

In PDP categorical_variables argument is unintuitive #39

mikolajsp opened this issue Jan 18, 2023 · 1 comment · Fixed by #55
Assignees
@mikolajsp
Labels
maintenance 🔨 Code enhancements, tests and maintenance

Comments

@mikolajsp
Copy link
Collaborator

No description provided.

@mikolajsp mikolajsp self-assigned this Feb 10, 2023
@mikolajsp mikolajsp added the maintenance 🔨 Code enhancements, tests and maintenance label Feb 10, 2023
@mikolajsp
Copy link
Collaborator Author

Perhaps

variables <- unique(c(variables, categorical_variables))

If someone uses this as intended, then nothing changes.

@mikolajsp mikolajsp linked a pull request Feb 16, 2023 that will close this issue
Change behavior of categorical_variables argument in model_profile() #55
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikolajsp mikolajsp

Labels
maintenance 🔨 Code enhancements, tests and maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change behavior of categorical_variables argument in model_profile() ModelOriented/survex
1 participant
@mikolajsp